Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing module implementation for Cmdliner_term_deprecated #147

Conversation

bcc32
Copy link

@bcc32 bcc32 commented Mar 28, 2022

Just a simple fix for a missing module implementation error that I discovered while trying to update the version of cmdliner used in nixpkgs. Here's the error I get when trying to build uuidm, for example:

ocamlfind ocamlopt -linkpkg -g -package cmdliner -package bytes -I src -I test src/uuidm.cmx test/uuidtrip.cmx -o test/uuidtrip.native
+ ocamlfind ocamlopt -linkpkg -g -package cmdliner -package bytes -I src -I test src/uuidm.cmx test/uuidtrip.cmx -o test/uuidtrip.native
File "_none_", line 1:
Error: No implementations provided for the following modules:
         Cmdliner_term_deprecated referenced from /nix/store/hd5n49fvwmhbxh9jyq9gjsj6d0qqhghm-ocaml4.13.1-cmdliner-1.1.1/lib/ocaml/4.13.1/site-lib/cmdliner/cmdliner.cmxa(Cmdliner)
Command exited with code 2.
pkg.ml: [ERROR] cmd ['ocamlbuild' '-use-ocamlfind' '-classic-display' '-j' '4' '-tag' 'debug'
     '-build-dir' '_build' 'opam' 'pkg/META' 'CHANGES.md' 'LICENSE.md'
     'README.md' 'src/uuidm.a' 'src/uuidm.cmxs' 'src/uuidm.cmxa'
     'src/uuidm.cma' 'src/uuidm.cmx' 'src/uuidm.cmi' 'src/uuidm.mli'
     'test/uuidtrip.native']: exited with 10

@dbuenzli
Copy link
Owner

dbuenzli commented Mar 28, 2022

Thanks!

However, is there any reason why you are not using theMakefile build ? That's the official build procedure (see the opam file).

The topkg build will be removed at some point.

@bcc32
Copy link
Author

bcc32 commented Mar 28, 2022

Hmm, I'm not the maintainer of the nixpkgs package for cmdliner, but I don't think there would be any objection to updating to the new build procedure. It's probably just out of date. Feel free to merge or close at your preference---it looks like there is no error when using the Makefile.

bcc32 added a commit to bcc32/nixpkgs that referenced this pull request Apr 6, 2022
According to
dbuenzli/cmdliner#147 (comment),
the topkg build is deprecated.  Switch to the new recommended build instructions.
vbgl pushed a commit to NixOS/nixpkgs that referenced this pull request Apr 7, 2022
* ocamlPackages.cmdliner: remove at 1.0.2

Remove a legacy version.

* ocamlPackages.cmdliner: use the upstream Makefile build rules

According to
dbuenzli/cmdliner#147 (comment),
the topkg build is deprecated.  Switch to the new recommended build instructions.
@dbuenzli dbuenzli closed this in bf25f97 Dec 15, 2022
@dbuenzli
Copy link
Owner

Thanks!

@bcc32 bcc32 deleted the fix-missing-impl-for-cmdliner-term-deprecated branch December 15, 2022 15:13
emillon pushed a commit to ocaml-dune/cmdliner that referenced this pull request Sep 25, 2023
emillon pushed a commit to ocaml-dune/cmdliner that referenced this pull request Sep 25, 2023
Signed-off-by: Etienne Millon <me@emillon.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants