Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#quit does not persist history and unsaved recorded phrases #6

Closed
dbuenzli opened this issue Jul 18, 2019 · 2 comments
Closed

#quit does not persist history and unsaved recorded phrases #6

dbuenzli opened this issue Jul 18, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@dbuenzli
Copy link
Owner

If one has unsaved recorded phrases, down takes care to save them on exit and reload them on the ocaml invocation. This however only works if the user exits with C-d as we don't get the hand back on #quit.

ocaml has a few life-cycle hooks but none of these happen at shutdown, likely something that should be considered in the context of ocaml/ocaml#7589.

down could try to patch the #quit directive but so far we didn't need to fiddle with those so I'm a bit reluctant to get into this.
@dbuenzli dbuenzli added the enhancement New feature or request label Jul 18, 2019
@dbuenzli
Copy link
Owner Author

Well in fact an atexit handler could do.

@dbuenzli
Copy link
Owner Author

And the same holds for history saving in fact.

@dbuenzli dbuenzli changed the title #quit does not persist unsaved recorded phrases #quit does not persist history and unsaved recorded phrases Jul 18, 2019
dbuenzli added a commit that referenced this issue Jul 18, 2019
@dbuenzli
Save history and unsaved recorded phrases using at_exit.
568d12d 
This entails correct behaviour on toplevel #quit. Closes (#6).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dbuenzli