#exec didnt like anything but strings as parameters, fixed

dburry · Jul 19, 2010 · 37864e0 · 37864e0
1 parent f82e6b3
commit 37864e0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/pdfkit/pdfkit.rb b/lib/pdfkit/pdfkit.rb
@@ -105,7 +105,7 @@ def normalize_value(value)
       when TrueClass
         nil
       else
-        value
+        value.to_s
       end
     end
 

diff --git a/spec/pdfkit_spec.rb b/spec/pdfkit_spec.rb
@@ -45,7 +45,7 @@
       pdfkit = PDFKit.new('html', :page_size => 'Letter', :toc_l1_font_size => 12)
       pdfkit.command[0].should include('wkhtmltopdf')
       pdfkit.command[pdfkit.command.index('--page-size') + 1].should == 'Letter'
-      pdfkit.command[pdfkit.command.index('--toc-l1-font-size') + 1].should == 12
+      pdfkit.command[pdfkit.command.index('--toc-l1-font-size') + 1].should == '12'
     end
 
     it "will not include default options it is told to omit" do
@@ -84,6 +84,18 @@
       pdf[0...4].should == "%PDF" # PDF Signature at beginning of file
     end
 
+    it "should generate a PDF with a numerical parameter" do
+      pdfkit = PDFKit.new('html', :header_spacing => 1)
+      pdf = pdfkit.to_pdf
+      pdf[0...4].should == "%PDF" # PDF Signature at beginning of file
+    end
+
+    it "should generate a PDF with a symbol parameter" do
+      pdfkit = PDFKit.new('html', :page_size => :Letter)
+      pdf = pdfkit.to_pdf
+      pdf[0...4].should == "%PDF" # PDF Signature at beginning of file
+    end
+
     it "should have the stylesheet added to the head if it has one" do
       pdfkit = PDFKit.new("<html><head></head><body>Hai!</body></html>")
       css = File.join(SPEC_ROOT,'fixtures','example.css')