-
Notifications
You must be signed in to change notification settings - Fork 13
zvariant: Type will fail silently if using with serde skip_serializing #309
Comments
If we could read |
In GitLab by @zhangyuannie on Dec 18, 2022, 23:55 I may have missed it but I didn't see this mentioned in the docs. 😅 seems to be more about the TypeDict use case. I'm trying to ask for the
My bad, I'm not too familiar with If doable, it would be awesome if something could be happening to indicate something went wrong. Thanks for taking the time. |
Oops, this was supposed to be #32.
As I said, If it's doable, then we can do the right thing and hence there is no warning needed. Keep in mind that I've not actually checked. If it's not doable, then we can't do warning either. |
marked this issue as a duplicate of #32 |
marked this issue as related to #32 |
In GitLab by @zhangyuannie on Dec 18, 2022, 08:03
See also https://serde.rs/field-attrs.html#skip_serializing
Ideally serde's features should work. Otherwise panicking could be very helpful to let the user know this feature is not supported with
Type
.For
skip_serializing
andskip_serializing_if
specifically, I believe this is due to serde not serializing the given field whileType
produce a signature with the skipped field, which I don't see an easy way to fix.skip_deserializing
probably have similar issue.The text was updated successfully, but these errors were encountered: