Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ zb: Add a from_bytes constructor for Message #370

Merged
merged 1 commit into from
Jun 13, 2023
Merged

✨ zb: Add a from_bytes constructor for Message #370

merged 1 commit into from
Jun 13, 2023

Conversation

SeaDve
Copy link
Contributor

@SeaDve SeaDve commented Jun 6, 2023 •
edited

Closes #326

zeenix
zeenix reviewed Jun 6, 2023
View reviewed changes
zbus/src/message.rs Outdated Show resolved Hide resolved
@SeaDve SeaDve changed the title ✨️ zb: impl TryFrom<Vec<u8>> for Message ✨ zb: Add a from_bytes constructor for Message Jun 7, 2023
zeenix
zeenix requested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

zbus/src/message.rs Outdated Show resolved Hide resolved
elmarco
elmarco suggested changes Jun 7, 2023
View reviewed changes
zbus/src/message.rs Outdated Show resolved Hide resolved
zbus/src/message.rs Outdated Show resolved Hide resolved
@SeaDve SeaDve force-pushed the try-from-vec-u8-message branch 3 times, most recently from d81838a to 6e70937 Compare June 12, 2023 01:02
zeenix
zeenix reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny fix and we're definitely good to merge. 👍

Thanks for your patience.

zbus/src/message.rs Outdated Show resolved Hide resolved
zbus/src/message.rs Outdated Show resolved Hide resolved
zeenix
zeenix approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zeenix zeenix enabled auto-merge June 13, 2023 10:41
@SeaDve
Copy link
Contributor Author

SeaDve commented Jun 13, 2023

Thanks for the reviews!

@zeenix zeenix merged commit ee7e2b2 into dbus2:main Jun 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmarco elmarco elmarco requested changes

@zeenix zeenix zeenix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an API similar to GDBusMessage::from_blob
3 participants
@SeaDve @zeenix @elmarco