✨ zv: impl Display for Value, Array, Structure, Dict & Maybe #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeenix
reviewed
Jun 11, 2023
zeenix
reviewed
Jun 11, 2023
SeaDve
force-pushed
the
value-display
branch
3 times, most recently
from
9838d17
to
dfe939d
Compare
zeenix
reviewed
Jun 12, 2023
zeenix
requested changes
Jun 23, 2023
SeaDve
force-pushed
the
value-display
branch
6 times, most recently
from
251cc5d
to
06d8cf1
Compare
|
Just FYI, related: #394 |
|
@SeaDve please let me know when this is ready from your side. |
|
Sorry for taking too long to reply, just finished my finals.
Sure |
|
I think it is now ready. The extra dep is now removed, and the debug impl of |
zeenix
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #366
Marked as a draft since bytestring and str Display implementations are currently broken on edge cases.