Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update play-ground.html #1083

Open
gordonwoodhull opened this issue Jan 8, 2016 · 1 comment
Open

update play-ground.html #1083

gordonwoodhull opened this issue Jan 8, 2016 · 1 comment
Labels
Milestone

Comments

@gordonwoodhull
Copy link
Contributor

This has been neglected since Nov 2013. At a quick glance I notice the following problems:

  • the choropleth is blank
  • date barchart has brush drawn over the whole area, and it can't be resized or reset.
  • brushing over the negative bar chart doesn't take - although this chart shows the new selection, the other charts rebound.
  • it would better to use controlsUseVisibility so they don't jump around when controls appear.
  • it seems to get into a loop and run continuously - from the start you can see the table being rebuilt a few times per second. transition.end spawns transitions? unclear. renderlets may be involved.
  • after about 30 seconds it spews hundreds of logs about drawing infinitesimals. after a few interactions these appear forever.

In addition it has a jerky easing behavior which was probably always there - it goes most of the way to where it's going and then pauses for half a second before bubbles/bars disappear/grow to size. Maybe due to the large number of charts?

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Jan 8, 2016
@gordonwoodhull
Copy link
Contributor Author

gordonwoodhull commented Dec 14, 2016

The playground also seems to have lent some very specific and suspicious CSS to the larger project, like

.dc-chart g.county path {
    stroke: white;
    fill: none;
}

It looks like dc.css was originally an example in test/ and got promoted to the library itself in 22789a0

We should review which CSS refers to objects created by code - anything created by an example should not be in dc.css.

It can cause weird accidental problems: http://stackoverflow.com/questions/41139341/dc-js-choropleth-map-chart-css-conflicting-with-colouring-no-map-showing-how-c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant