Use crossfilter2 in footer, on the AMD path. #1213
Conversation
|
@vprus, does the This solution breaks vanilla AMD, and I'd rather keep the |
|
I'm going to write this off as a configuration issue, unless I hear otherwise. It's unfortunate that the module name is different from the filename (and the function object name), but that's where we are at. Maybe someday the community fork of crossfilter will change enough to merit its own name, but for now it is a drop-in replacement |
this breaks requireJS but fixes webpack - since the community fork of crossfilter has a different package name from its filename, one or the other packaging system is going to be unhappy. requireJS users will need to rename crossfilter.js to crossfilter2.js when copying it into position, or use the requireJS paths or map configuration options to specify that the filename is different from the module name. http://requirejs.org/docs/api.html#config-paths http://requirejs.org/docs/api.html#config-map fixes #1213 fixes #1214 fixes #1261 fixes #1293 fixes #1302 breaks #1304!
|
As of dc.js 2.0.3 / 2.1.6, we'll break requireJS compatibility in favor of webpack compatibility. See #1304 if this creates problems for you. |
I've tried to use current DC inside react, using https://github.com/facebookincubator/create-react-app, and DC could not find crossfilter. Looks like 'crossfilter' was changed to 'crossfilter2' on one path, but not another. I have no idea why react build process uses AMD modules, but this patch fixes the error.