You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently some of the examples use deprecated calls. These examples are supposed to be used by users as samples, so, these need to be inline with best practices that DC team suggests.
Currently code quality in examples vary widely. In this regard we can also check feasibility of adding linting to examples. If that works then we will have some basic quality assured.
The text was updated successfully, but these errors were encountered:
I agree should remove any deprecated API calls from the examples, and improve code to make it "exemplary".
I'm less sure that linting will help, since that's mostly stylistic. I think that will mostly result in re-indenting everything. Although I'm sometimes annoyed by the indentation, commits for indentation cause a break in history: git blame no longer works so it takes a lot longer to determine the intent of any line of code.
Overall I am 👍 for human intervention but 😐 for machine intervention in the examples.
Currently some of the examples use deprecated calls. These examples are supposed to be used by users as samples, so, these need to be inline with best practices that DC team suggests.
Currently code quality in examples vary widely. In this regard we can also check feasibility of adding linting to examples. If that works then we will have some basic quality assured.
The text was updated successfully, but these errors were encountered: