Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated calls from Examples #1415

Open
kum-deepak opened this issue Apr 17, 2018 · 3 comments
Open

Remove deprecated calls from Examples #1415

kum-deepak opened this issue Apr 17, 2018 · 3 comments
Labels
Milestone

Comments

@kum-deepak
Copy link
Collaborator

Currently some of the examples use deprecated calls. These examples are supposed to be used by users as samples, so, these need to be inline with best practices that DC team suggests.

Currently code quality in examples vary widely. In this regard we can also check feasibility of adding linting to examples. If that works then we will have some basic quality assured.

@gordonwoodhull
Copy link
Contributor

I agree should remove any deprecated API calls from the examples, and improve code to make it "exemplary".

I'm less sure that linting will help, since that's mostly stylistic. I think that will mostly result in re-indenting everything. Although I'm sometimes annoyed by the indentation, commits for indentation cause a break in history: git blame no longer works so it takes a lot longer to determine the intent of any line of code.

Overall I am 👍 for human intervention but 😐 for machine intervention in the examples.

@kum-deepak
Copy link
Collaborator Author

😄 did not think this angle. I will only look for human changes.

@kum-deepak kum-deepak added this to the dc-v5 milestone Aug 16, 2020
@kum-deepak
Copy link
Collaborator Author

With the dc-v5 release, examples change significantly, so, it may be a good time to consider this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants