Skip to content

Commit

Permalink
doors: Abort transfer if file is deleted during pool selection
Browse files Browse the repository at this point in the history
Motivation:

If a file is deleted during pool selection, the Transfer class gets
caught in the retry loop (until the limit is reached) as it doesn't
recognize the failure as a permanent error.

Modification:

Abort the transfer if the file is deleted.

Result:

Fixed an issue in which doors could get temporarily stuck in a
retry loop if the file was deleted during pool selection.

Target: trunk
Require-notes: yes
Require-book: no
Request: 2.16
Request: 2.15
Request: 2.14
Request: 2.13
Acked-by: Paul Millar <paul.millar@desy.de>

Reviewed at https://rb.dcache.org/r/9681/

(cherry picked from commit f2b6b24)
  • Loading branch information
gbehrmann committed Aug 29, 2016
1 parent 681b1df commit 2b526ee
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions modules/dcache/src/main/java/org/dcache/util/Transfer.java
Original file line number Diff line number Diff line change
Expand Up @@ -1221,6 +1221,7 @@ public ListenableFuture<Void> apply (CacheException t) throws Exception
return retryWhen(immediateFuture(null));
case CacheException.FILE_IN_CACHE:
case CacheException.INVALID_ARGS:
case CacheException.FILE_NOT_FOUND:
return immediateFailedFuture(t);
case CacheException.NO_POOL_CONFIGURED:
_log.error(t.getMessage());
Expand Down

0 comments on commit 2b526ee

Please sign in to comment.