Support running action inside containers #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaxBusby
force-pushed
the
container-compat
branch
from
97a706e
to
a039cbb
Compare
TaxBusby
commented
Nov 7, 2023
| { | ||
| exit 1 | ||
| } | ||
| test-container: |
There was a problem hiding this comment.
The diff makes this hard to read, but I effectively duplicated the test-linux job here, removed non-linux matrix cases, and set up a container to run the tests.
tsang-bot bot
added a commit
to tsangste/nx-package-test
that referenced
this pull request
Nov 12, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [dcarbone/install-jq-action](https://togithub.com/dcarbone/install-jq-action) | action | minor | `v2.0.2` -> `v2.1.0` | --- ### Release Notes <details> <summary>dcarbone/install-jq-action (dcarbone/install-jq-action)</summary> ### [`v2.1.0`](https://togithub.com/dcarbone/install-jq-action/releases/tag/v2.1.0) [Compare Source](https://togithub.com/dcarbone/install-jq-action/compare/v2.0.2...v2.1.0) #### What's Changed - Support running action inside containers by [@​TaxBusby](https://togithub.com/TaxBusby) in [dcarbone/install-jq-action#10 #### New Contributors - [@​TaxBusby](https://togithub.com/TaxBusby) made their first contribution in [dcarbone/install-jq-action#10 **Full Changelog**: dcarbone/install-jq-action@v2.0.2...v2.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNTYuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Co-authored-by: tsang-bot[bot] <146107447+tsang-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
${{ github.action_path }}to${GITHUB_ACTION_PATH}to fix container compatibility, per github.action_path contains wrong path when used inside a container actions/runner#2185 (comment)Windows cases are unchanged since
container:options are only supported for linux runners, and I don't know powershell syntax.Testing