Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TokenInHeader to default to true #18

Merged
merged 1 commit into from
Jul 5, 2020
Merged

TokenInHeader to default to true #18

merged 1 commit into from
Jul 5, 2020

Conversation

slt
Copy link
Contributor

@slt slt commented Jul 2, 2020

Passing tokens in the query string is not recommended
and this should default to the more secure behaviour

Passing tokens in the query string is not recommended
and this should default to the more secure behaviour
Copy link
Owner

@dcarbone dcarbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@dcarbone dcarbone merged commit da30ec9 into dcarbone:master Jul 5, 2020
@slt
Copy link
Contributor Author

slt commented Jul 14, 2020

@dcarbone Thank you for reviewing and merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants