Fixed displaying nested containers #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue I had locally with containers not being displayed.
Probably fixes #46, but I'm not sure.
The
nextTicktakes care of waiting for the deletion of an attribute before registering new dependency watchers. This was an issue because the watchers work in chronological order. When a component is mounted that depends on an attribute and another component with the same dependency is being unmounted afterwards, the attribute will be deleted after registering the dependencies, so the!valueBag.hasOwnProperty(attribute)check in theregisterDependencyWatchersmethod will return false.I also added
parseIntto theattributeValueinexecuteCondition, so comparing integers works better. I'm not sure if it breaks anything, so feel free to remove it if it does.