Skip to content

Commit

Permalink
comma left off causing invalid flow
Browse files Browse the repository at this point in the history
in the hybrid overlay there was a comma missing from a flow
between the nw_src and action. Adding the comma fixes the flow.

Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com>
  • Loading branch information
JacobTanenbaum committed Jul 6, 2022
1 parent ab7f0e6 commit 0582cf4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions go-controller/hybrid-overlay/pkg/controller/node_linux.go
Expand Up @@ -214,7 +214,7 @@ func (n *NodeController) hybridOverlayNodeUpdate(node *kapi.Node) error {
cookie, cidr.String(), hotypes.HybridOverlayVNI, nodeIP.String(), drMAC.String()))

flows = append(flows,
fmt.Sprintf("cookie=0x%s,table=0,priority=101,ip,nw_dst=%s,nw_src=%s"+
fmt.Sprintf("cookie=0x%s,table=0,priority=101,ip,nw_dst=%s,nw_src=%s,"+
"actions=load:%d->NXM_NX_TUN_ID[0..31],"+
"set_field:%s->nw_src,"+
"set_field:%s->tun_dst,"+
Expand Down Expand Up @@ -629,9 +629,9 @@ func (n *NodeController) syncFlows() {
flows = append(flows, entry.learnedFlow)
}
}
_, _, err = util.ReplaceOFFlows(extBridgeName, flows)
_, stderr, err = util.ReplaceOFFlows(extBridgeName, flows)
if err != nil {
klog.Errorf("Failed to add flows, error: %v, flows: %s", err, flows)
klog.Errorf("Failed to add flows, error: %v, stderr: %s, flows: %s", err, stderr, flows)
}
}

Expand Down

0 comments on commit 0582cf4

Please sign in to comment.