Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script still refers to "master" branch #47

Closed
wjdhamilton opened this issue Aug 10, 2022 · 6 comments
Closed

Install script still refers to "master" branch #47

wjdhamilton opened this issue Aug 10, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@wjdhamilton
Copy link

Describe the bug
When attempting to install using vim-plug the following error occurs:

fatal: invalid reference: master

To Reproduce
Steps to reproduce the behavior:

Install the plugin per the instructions for vim-plug, i.e.:

Plug 'dccsillag/magma-nvim', { 'do': ':UpdateRemotePlugins' }

Expected behavior
Vim-plug confirms the plugin installed properly

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot 2022-08-10 at 12 34 44

Desktop (please complete the following information):

  • OS: MacOS 12.5
  • Browser: N/A
@wjdhamilton wjdhamilton added the bug Something isn't working label Aug 10, 2022
@dccsillag
Copy link
Owner

dccsillag commented Aug 10, 2022

There isn't an install script; :UpdateRemotePlugins is just a NeoVim command to register remote plugins (which this is one of).

So, as it is, there actually isn't anything referring to the master branch specifically there. In fact:

magma-nvim  main [~u] $ rg master
magma-nvim  main [~u] ✗ 1 $

That is, there is no mention of the master branch anywhere in this repo.

I remember experiencing similar issues with vim-plug, though (but with other plugins) -- I don't know why it happens. My workaround was to add a , branch: 'main' to the options table:

Plug 'dccsillag/magma-nvim', { 'do': ':UpdateRemotePlugins', 'branch': 'main' }

@wjdhamilton
Copy link
Author

wjdhamilton commented Aug 10, 2022 via email

@wjdhamilton
Copy link
Author

wjdhamilton commented Aug 11, 2022 via email

@dccsillag
Copy link
Owner

dccsillag commented Aug 11, 2022

The magma-nvim  main [~u] $ is my shell's prompt: magma-nvim is the directory name,  main indicates that I'm on branch main, [~u] indicates that there are unstaged files (u) and modified files (~) (and my git diff does not touch anything mentioning any branches, just some internal logic), and $ is a prompt character separator.

Then, the command rg master uses ripgrep; think of it as grep -r master . but that ignores things in the gitignore & .git, and is overall faster (there are more differences, but that's the gist of it here; it's quite practical). It doesn't give any output, which indicates that there is no file in the repository where the pattern master can be found.

@wjdhamilton
Copy link
Author

wjdhamilton commented Aug 11, 2022 via email

@dccsillag
Copy link
Owner

dccsillag commented Aug 11, 2022

Ah, no worries! Glad to have helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants