Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Grant creation approval notice after creation #254

Closed
phutchins opened this issue Sep 17, 2021 · 6 comments · Fixed by #317
Closed

UI: Grant creation approval notice after creation #254

phutchins opened this issue Sep 17, 2021 · 6 comments · Fixed by #317
Assignees
Labels
app Frontend issues POC

Comments

@phutchins
Copy link
Contributor

phutchins commented Sep 17, 2021

After a grant is created, the user should be informed that their grant will not show up immediately and will only be displayed after review and approval.

Requirements

  • After submitting a grant, user should be redirected to /dgrants/grant-submitted page (or other appropriate name)
  • grant-submitted page should say "Thank you for your grant submission! \n Your grant has been queue'd for review and upon approval will be visible to everyone. \n Average time to review is less than 24 hours."
  • No button should be necessary to go back home as the navigation should provide all that is necessary
@phutchins phutchins added app Frontend issues POC labels Sep 17, 2021
@metafraction
Copy link
Member

metafraction commented Sep 27, 2021

Any suggestions on how to handle this? Should we add in a message on the confirmation page?

@thelostone-mc
Copy link
Collaborator

thelostone-mc commented Sep 28, 2021

^ cc @scco

@mk1r I think we should use the UI toasters we have (the one in which errors show up)
The other question here is -> does this mean on completion of creation of grant we redirect them to grant list page ?
@phutchins

@mds1
Copy link
Contributor

mds1 commented Sep 28, 2021

@mk1r I think we should use the UI toasters we have (the one in which errors show up)

Agreed, this is the simplest and works for now. We can always do something fancier later if we need to.

However, @scco, it looks like the notification toasters are styled to look identical regardless of which alertType is used, which seems not ideal—i.e. there's no way to distinguish between positive, neutral, or negative alerts without reading the message

The other question here is -> does this mean on completion of creation of grant we redirect them to grant list page ?
@phutchins

I'd say yes, not sure of a better page to redirect to

@scco
Copy link
Contributor

scco commented Sep 29, 2021

my proposal for

NOW
on successfully submit a grant , redirect to a page like
/dgrants/grant-successfully-submited
what just have some generic "thank you we review your grant" + what ever button to home view.

LATER
i planed to have routes for a user/ethereumaddress to views like :
"my profile", "my favorites", "my grants", "my settings" ...

so later we would want to redirect from a successfully submitted grant to the "my grants" view,
where a user should then see his new created grant with a "under review" label.
in best case with NO under review label - as i thought everybody can create grants.


so i would suggest to just create a new route and a temporary static page grant-successfully-submited.vue for now, and let me style it a bit. content suggestions welcome. if you agree on this plan as it is simple to achieve and just need to replace the redirect url to a user-area later on - ping me on what branch i can modify the new view/route and i help on that :)

@phutchins
Copy link
Contributor Author

Added spec/requirements to initial comment.

@metafraction
Copy link
Member

closing in favor of discussion #320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Frontend issues POC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants