Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable WETH & ETH Donations In Same Checkout #98

Open
apbendi opened this issue Aug 11, 2021 · 0 comments
Open

Enable WETH & ETH Donations In Same Checkout #98

apbendi opened this issue Aug 11, 2021 · 0 comments
Labels
contracts Smart contract issues
Projects

Comments

@apbendi
Copy link
Collaborator

apbendi commented Aug 11, 2021

A limitation that results from this is you can't donate WETH and ETH in the same transaction, which I think is an edge case that's ok if we don't support. Wonder if Uniswap V3 router would let you multicall an ETH->DAI and WETH->DAI swap in the same transaction. My guess it supports that via multicall where you deposit ETH->WETH in the router as the first call, then execute the swap as the next call.

-- @mds1

Context

@apbendi apbendi added the contracts Smart contract issues label Aug 11, 2021
@apbendi apbendi added this to To Do in dGrants via automation Aug 11, 2021
@mds1 mds1 mentioned this issue Aug 23, 2021
3 tasks
@phutchins phutchins moved this from To Do to Backlog in dGrants Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Smart contract issues
Projects
dGrants
Backlog
Development

No branches or pull requests

1 participant