GrantsRound contract with tests #17
Conversation
corydickson
requested review from
wildmolasses,
mds1,
phutchins,
apbendi,
frankchen07,
jferas and
thelostone-mc
and removed request for
wildmolasses and
mds1
There was a problem hiding this comment.
Looks great overall!
Left a lot of comments, but mostly best practices type of things. There's also been a lot of discussion in #12 so we should review that and make sure any changes/new requirements are accounted for here
The biggest change I mentioned is that I think we should switch from a Waffle mock to an actual mock token contract that behaves like an ERC20, since it seems there's a few issues/bugs that arise/aren't caught with the Waffle mock approach.
There was a problem hiding this comment.
Great start! Left some additional feedback and responses to others comments. LMK if you have any follow up. Thanks @corydickson.
There was a problem hiding this comment.
Thanks for addressing the feedback @corydickson. Added a couple commits to address very minor issues, including minor formatting changes, and making the failing test skipped instead so it doesn't result in failing CI once #25 is merged.
* Add needed '/' to storage var natspec comments * Add newlines between storage var declarations * Add header comments between different code sections
apbendi
force-pushed
the
cd/grant-round-contract
branch
from
e56ba8a
to
1763f3d
Compare
Addresses #12