Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold monorepo #2

Merged
merged 15 commits into from
Jul 8, 2021
Merged

Scaffold monorepo #2

merged 15 commits into from
Jul 8, 2021

Conversation

wildmolasses
Copy link
Contributor

@wildmolasses wildmolasses commented Jul 1, 2021 •
edited by apbendi
Loading

Monorepo with /app and /contracts folders!

Make sure to install volta and check the README's for other dev setup instructions and flow.

@wildmolasses wildmolasses marked this pull request as ready for review July 2, 2021 04:02
@wildmolasses wildmolasses changed the title Monorepo Scaffold monorepo Jul 2, 2021
@apbendi apbendi marked this pull request as draft July 2, 2021 14:50
mds1
mds1 requested changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@mds1 mds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Was able to build both the contracts and app folders

README.md Outdated Show resolved Hide resolved
app/package.json Outdated Show resolved Hide resolved
contracts/package.json Outdated Show resolved Hide resolved
contracts/types/augmentations.d.ts Outdated Show resolved Hide resolved
tsconfig.settings.json Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@wildmolasses wildmolasses requested a review from mds1 July 4, 2021 16:07
@apbendi apbendi marked this pull request as ready for review July 7, 2021 02:04
@apbendi apbendi requested review from phutchins and jferas July 7, 2021 02:10
mds1
mds1 reviewed Jul 7, 2021
View reviewed changes
contracts/hardhat.config.ts Outdated Show resolved Hide resolved
phutchins
phutchins approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@phutchins phutchins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments but other than that all looks good! It builds and runs for me and everything feels clean.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
app/src/components/LayoutFooter.vue Outdated Show resolved Hide resolved
app/src/components/LayoutFooter.vue Outdated Show resolved Hide resolved
app/src/components/LayoutFooter.vue Outdated Show resolved Hide resolved
app/README.md Show resolved Hide resolved
@mds1 mds1 mentioned this pull request Jul 7, 2021
Closed
@phutchins phutchins merged commit 4bba709 into main Jul 8, 2021
@phutchins phutchins deleted the monorepo branch July 8, 2021 14:01
@metafraction metafraction mentioned this pull request Nov 18, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phutchins phutchins phutchins approved these changes

@apbendi apbendi apbendi left review comments

@mds1 mds1 mds1 requested changes

@jferas jferas Awaiting requested review from jferas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wildmolasses @phutchins @apbendi @mds1 @jferas