Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 'require is not defined' on prod for walletconnect #564

Merged
merged 2 commits into from Dec 3, 2021
Merged

fix: 'require is not defined' on prod for walletconnect #564

merged 2 commits into from Dec 3, 2021

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Dec 3, 2021

Resolves #555, see that issue for details

This is not yet tested since this issue only happens in production build. @phutchins do branches deploy to a staging env we can test this on before merging?

metafraction
metafraction approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@metafraction metafraction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not entirely sure how your change fixes it, but looking good!

@apbendi
Publish
ab6077e 
 - @dgrants/app@0.2.27-87d3139.0
 - @dgrants/contracts@0.2.24-87d3139.0
 - @dgrants/dcurve@0.2.24-87d3139.0
 - @dgrants/types@0.2.24-87d3139.0
@apbendi apbendi merged commit ab6077e into main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metafraction metafraction metafraction approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Walletconnect throwing error
3 participants
@mds1 @metafraction @apbendi