Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment instead of daemonset? #2

Open
dcherman opened this issue Apr 1, 2021 · 0 comments
Open

deployment instead of daemonset? #2

dcherman opened this issue Apr 1, 2021 · 0 comments

Comments

@dcherman
Copy link
Owner

dcherman commented Apr 1, 2021

the usage of a daemonset is no longer strictly necessary. originally, the daemonset was used in order to add labels to individual pods for use with podAffinity in order to have argo target nodes that already had the images pre-pulled, however that's actually already a factor in the kubernetes scheduler algo

we can swap to using a deployment instead and reduce the number of controller pods that we need down to 1, although we would need to add privileges to get/list/watch nodes, and we lose the ability to target specific nodes for image pre-pulling which could be implemented taints/tolerations/nodeSelector on the daemonset right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant