-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@media #7
Comments
I think your solution is a good one, we could make a method to sub-process that line of the Anyway I will think about other solutions.. thanks |
I'm seeing this issue as well. |
Seems a pretty good fix to do by adding an additional check. Didn't have the time yet to implement it. I will try it whenever I have time for this, please feel free to contribute |
I'm still having this issue as well, given: @media(min-width:1200px) {
.timeline>li {
min-height: 170px;
}
} Css2stylus outputs: @media(min-width
&:1200px)
.timeline>li {
min-height 170px |
Still having this issue too @media
(max-width
&:
767px)
before {
left 40px
ul
&.timeline
& > li
margin-bottom 20px
position relative
width 100%
float left
clear left |
this needs to be addressed in a special case. open to contributions :) will try to fix it at some point |
Honestly, it's not a feature, but a straight up bug. :| |
well as I see it is a feature. because this version i never made any special implementation for handling media queries. so if support is something is needed to be implemented (not fixed) is a feature. not a bug |
and what i meant above in my previous comment by "fix" was about fixing the github issue by implementing this feature. thanks for the contribution |
+1 |
Hi, any news on this ? |
i am pretty busy to handle this now, please feel free to contribute. On Wed, Oct 28, 2015 at 10:08 AM, Pierre de la Martinière <
|
I just submitted a pull request that should fix this issue |
So @media tags aren't rendering so well right now.
input:
output:
It looks like the code is treating the spaces as additional selectors because it's getting through to line 109
selectors = selector.split(/[\s]+/);
Maybe we should add another check to the
if
statement on line 99 to see if the selector starts with@media
then process the contents of that block recursively?The way it is now doing that recursively would require a lot of rewriting. Maybe there's a better way. What are your thoughts?
The text was updated successfully, but these errors were encountered: