Skip to content

Commit

Permalink
create a .jshintrc-base file
Browse files Browse the repository at this point in the history
  • Loading branch information
@dciccale
dciccale committed Aug 5, 2015
1 parent 1c53063 commit 375428d
Show file tree
Hide file tree
Showing 9 changed files with 112 additions and 117 deletions.
11 changes: 1 addition & 10 deletions .jshintrc
View file
Original file line number Diff line number Diff line change
@@ -1,13 +1,4 @@
{
"latedef": true,
"noempty": true,
"curly": true,
"eqeqeq": true,
"immed": true,
"noarg": true,
"quotmark": "single",
"undef": true,
"unused": true,
"trailing": true,
"extends": ".jshintrc-base",
"node": true
}
15 changes: 15 additions & 0 deletions .jshintrc-base
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"camelcase": true,
"latedef": true,
"noempty": true,
"curly": true,
"eqeqeq": true,
"immed": true,
"noarg": true,
"quotmark": "single",
"undef": true,
"unused": true,
"trailing": true,
"forin": true,
"strict": true
}
14 changes: 1 addition & 13 deletions src/.jshintrc
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,5 @@
{
"camelcase": true,
"curly": true,
"eqeqeq": true,
"forin": true,
"immed": true,
"latedef": true,
"noarg": true,
"noempty": true,
"quotmark": "single",
"undef": true,
"unused": true,
"strict": true,
"trailing": true,
"extends": "../.jshintrc-base",
"browser": true,
"globals": {
"Kimbo": true,
Expand Down
11 changes: 1 addition & 10 deletions test/.jshintrc
View file
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
{
"onevar": true,
"boss": true,
"latedef": true,
"noempty": true,
"curly": true,
"immed": true,
"noarg": true,
"undef": true,
"unused": true,
"trailing": true,
"extends": "../.jshintrc-base",
"browser": true,
"mocha": true,
"globals": {
Expand Down
2 changes: 2 additions & 0 deletions test/core.js
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/*jshint -W030 */
describe('core', function () {
'use strict';

var el = null;
var fixture = spec.getFixture();

Expand Down
2 changes: 2 additions & 0 deletions test/data.js
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
describe('data', function () {
'use strict';

it('should store data in elements', function () {
var $el = $(document.createElement('div'));
expect($el.data('key')).to.equal(void 0);
Expand Down
168 changes: 85 additions & 83 deletions test/manipulation.js
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
/*jshint -W030 */
describe('manipulation', function () {
'use strict';

var query = null;
var el = null;
var $li_first = null;
var $li_second = null;
var $liFirst = null;
var $liSecond = null;
var $input = null;
var fixture = spec.getFixture();

Expand All @@ -15,8 +17,8 @@ describe('manipulation', function () {
el = fixture.cloneNode(true);
document.body.appendChild(el);

$li_first = $('li.first');
$li_second = $('li#second');
$liFirst = $('li.first');
$liSecond = $('li#second');
$input = $('#name');
query = Kimbo.require('query');
});
Expand All @@ -39,12 +41,12 @@ describe('manipulation', function () {
});

it('should return the textContent of an element', function () {
expect($li_first.text()).to.equal('uno');
expect($liFirst.text()).to.equal('uno');
});

it('should set the textContent of an element', function () {
$li_first.text('one');
expect($li_first.text()).to.equal('one');
$liFirst.text('one');
expect($liFirst.text()).to.equal('one');
});
});

Expand All @@ -62,14 +64,14 @@ describe('manipulation', function () {
it('should return the innerHTML of an element', function () {
var html;
html = document.getElementById('second').innerHTML;
expect($li_second.html()).to.equal(html);
expect($liSecond.html()).to.equal(html);
});

it('should set the innerHTML of an element', function () {
var content;
content = '<span>dos</span>';
$li_second.html(content);
expect($li_second.html()).to.equal(content);
$liSecond.html(content);
expect($liSecond.html()).to.equal(content);
});

});
Expand Down Expand Up @@ -107,19 +109,19 @@ describe('manipulation', function () {
});

it('should add a class to an element', function () {
$li_first.addClass('uno');
expect(getClass($li_first)).to.deep.equal(['first', 'active', 'uno']);
$liFirst.addClass('uno');
expect(getClass($liFirst)).to.deep.equal(['first', 'active', 'uno']);
});

it('should only add a class if the nodeType is 1 (ELEMENT_NODE)', function () {
var textNode;
textNode = $($li_first[0].firstChild);
textNode = $($liFirst[0].firstChild);
expect(textNode.addClass('text_node')).to.equal(textNode);
});

it('should add multiple classes to an element', function () {
$li_second.addClass('dos two due');
expect(getClass($li_second)).to.deep.equal(['dos', 'two', 'due']);
$liSecond.addClass('dos two due');
expect(getClass($liSecond)).to.deep.equal(['dos', 'two', 'due']);
});

it('should add multiple classes to multiple elements', function () {
Expand All @@ -132,43 +134,43 @@ describe('manipulation', function () {

it('should not fail when called with weird or without arguments', function () {
expect(function () {
$li_second.addClass();
$liSecond.addClass();
}).to.not.throw();

expect(function () {
$li_second.addClass('');
$liSecond.addClass('');
}).to.not.throw();

expect(function () {
$li_second.addClass(null);
$liSecond.addClass(null);
}).to.not.throw();

expect(function () {
$li_second.addClass(true);
$liSecond.addClass(true);
}).to.not.throw();

expect(function () {
$li_second.addClass([]);
$liSecond.addClass([]);
}).to.not.throw();

expect(function () {
$li_second.addClass({});
$liSecond.addClass({});
}).to.not.throw();
});

it('should do nothing when called with wierd or without arguments', function () {
var currentClasses = getClass($li_first);
$li_first.addClass();
expect(getClass($li_first)).to.deep.equal(currentClasses);
$li_first.addClass('');
expect(getClass($li_first)).to.deep.equal(currentClasses);
$li_first.addClass(null);
expect(getClass($li_first)).to.deep.equal(currentClasses);
$li_first.addClass(true);
expect(getClass($li_first)).to.deep.equal(currentClasses);
$li_first.addClass([]);
expect(getClass($li_first)).to.deep.equal(currentClasses);
$li_first.addClass({});
var currentClasses = getClass($liFirst);
$liFirst.addClass();
expect(getClass($liFirst)).to.deep.equal(currentClasses);
$liFirst.addClass('');
expect(getClass($liFirst)).to.deep.equal(currentClasses);
$liFirst.addClass(null);
expect(getClass($liFirst)).to.deep.equal(currentClasses);
$liFirst.addClass(true);
expect(getClass($liFirst)).to.deep.equal(currentClasses);
$liFirst.addClass([]);
expect(getClass($liFirst)).to.deep.equal(currentClasses);
$liFirst.addClass({});
});
});

Expand All @@ -180,64 +182,64 @@ describe('manipulation', function () {
});

it('should remove a class from an element', function () {
$li_first.removeClass('uno');
expect(getClass($li_first)).to.deep.equal(['first', 'active']);
$liFirst.removeClass('uno');
expect(getClass($liFirst)).to.deep.equal(['first', 'active']);
});

it('should only add a class if the nodeType is 1 (ELEMENT_NODE)', function () {
var textNode;
textNode = $($li_first[0].firstChild);
textNode = $($liFirst[0].firstChild);
expect(textNode.removeClass('text_node')).to.equal(textNode);
});

it('should remove multiple classes from an element', function () {
$li_second[0].className = 'dos due';
$li_second.removeClass('dos due');
expect(getClass($li_second)).to.deep.equal(['']);
$liSecond[0].className = 'dos due';
$liSecond.removeClass('dos due');
expect(getClass($liSecond)).to.deep.equal(['']);
});

it('should remove all classes from an element if called without arguments', function () {
$li_second[0].className = 'test multiple';
$li_second.removeClass();
expect(getClass($li_second)).to.deep.equal(['']);
$li_second[0].className = 'test multiple';
$li_second.removeClass('');
expect(getClass($li_second)).to.deep.equal(['']);
$liSecond[0].className = 'test multiple';
$liSecond.removeClass();
expect(getClass($liSecond)).to.deep.equal(['']);
$liSecond[0].className = 'test multiple';
$liSecond.removeClass('');
expect(getClass($liSecond)).to.deep.equal(['']);
});

it('should not fail when called with wierd arguments', function () {
expect(function () {
$li_second.removeClass(null);
$liSecond.removeClass(null);
}).to.not.throw();
expect(function () {
$li_second.removeClass(true);
$liSecond.removeClass(true);
}).to.not.throw();
expect(function () {
$li_second.removeClass([]);
$liSecond.removeClass([]);
}).to.not.throw();
expect(function () {
$li_second.removeClass({});
$liSecond.removeClass({});
}).to.not.throw();
});

it('should do nothing when called with wierd arguments', function () {
var currentClasses = getClass($li_first);
$li_first.removeClass([]);
expect(getClass($li_first)).to.deep.equal(currentClasses);
$li_first.removeClass({});
expect(getClass($li_first)).to.deep.equal(currentClasses);
var currentClasses = getClass($liFirst);
$liFirst.removeClass([]);
expect(getClass($liFirst)).to.deep.equal(currentClasses);
$liFirst.removeClass({});
expect(getClass($liFirst)).to.deep.equal(currentClasses);
});

it('should remove all clases from an element when falsy values passed', function () {
$li_second[0].className = 'has multiple classes';
$li_second.removeClass(false);
expect(getClass($li_second)).to.deep.equal(['']);
$li_second[0].className = 'has multiple classes';
$li_second.removeClass(null);
expect(getClass($li_second)).to.deep.equal(['']);
$li_second[0].className = 'has multiple classes';
$li_second.removeClass(0);
expect(getClass($li_second)).to.deep.equal(['']);
$liSecond[0].className = 'has multiple classes';
$liSecond.removeClass(false);
expect(getClass($liSecond)).to.deep.equal(['']);
$liSecond[0].className = 'has multiple classes';
$liSecond.removeClass(null);
expect(getClass($liSecond)).to.deep.equal(['']);
$liSecond[0].className = 'has multiple classes';
$liSecond.removeClass(0);
expect(getClass($liSecond)).to.deep.equal(['']);
});
});

Expand All @@ -249,8 +251,8 @@ describe('manipulation', function () {
});

it('should return whether an element has the specified class', function () {
expect($li_first.hasClass('first')).to.be.true;
expect($li_first.hasClass('second')).to.be.false;
expect($liFirst.hasClass('first')).to.be.true;
expect($liFirst.hasClass('second')).to.be.false;
});

it('should return whether multiple elements has the specified class', function () {
Expand All @@ -262,12 +264,12 @@ describe('manipulation', function () {
});

it('should return false when weird or no arguments are passed', function () {
expect($li_first.hasClass()).to.be.false;
expect($li_first.hasClass('')).to.be.false;
expect($li_first.hasClass(true)).to.be.false;
expect($li_first.hasClass(false)).to.be.false;
expect($li_first.hasClass([])).to.be.false;
expect($li_first.hasClass({})).to.be.false;
expect($liFirst.hasClass()).to.be.false;
expect($liFirst.hasClass('')).to.be.false;
expect($liFirst.hasClass(true)).to.be.false;
expect($liFirst.hasClass(false)).to.be.false;
expect($liFirst.hasClass([])).to.be.false;
expect($liFirst.hasClass({})).to.be.false;
});
});

Expand All @@ -279,30 +281,30 @@ describe('manipulation', function () {
});

it('should add the class if the element has not that class', function () {
$li_second.toggleClass('toggle');
expect(getClass($li_second)).to.deep.equal(['toggle']);
$liSecond.toggleClass('toggle');
expect(getClass($liSecond)).to.deep.equal(['toggle']);
});

it('should remove the class if the element has that class', function () {
$li_second[0].className = 'toggle';
$li_second.toggleClass('toggle');
expect(getClass($li_second)).to.deep.equal(['']);
$liSecond[0].className = 'toggle';
$liSecond.toggleClass('toggle');
expect(getClass($liSecond)).to.deep.equal(['']);
});

it('should add toggle multiple classes', function () {
$li_second.toggleClass('toggle toggle2 toggle3');
expect(getClass($li_second)).to.deep.equal(['toggle', 'toggle2', 'toggle3']);
$liSecond.toggleClass('toggle toggle2 toggle3');
expect(getClass($liSecond)).to.deep.equal(['toggle', 'toggle2', 'toggle3']);
});

it('should remove toggle multiple classes', function () {
$li_second[0].className = 'toggle toggle2 toggle3';
$li_second.toggleClass('toggle toggle2 toggle3');
expect(getClass($li_second)).to.deep.equal(['']);
$liSecond[0].className = 'toggle toggle2 toggle3';
$liSecond.toggleClass('toggle toggle2 toggle3');
expect(getClass($liSecond)).to.deep.equal(['']);
});

it('should accept a bool second parameter indicating wather to add or remove a class', function () {
$li_second.toggleClass('toggle', false);
expect(getClass($li_second)).to.deep.equal(['']);
$liSecond.toggleClass('toggle', false);
expect(getClass($liSecond)).to.deep.equal(['']);
});
});

Expand Down
Loading

0 comments on commit 375428d

Please sign in to comment.