Fix color assignment in 2D Histogram (Fix #310) #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think color information in the 2D histogram is being stored in row-major order, while the bincounts are stored in column-major order.
Gives the following
![672a6d8](https://cloud.githubusercontent.com/assets/7328215/3183177/293a3e50-ec64-11e3-8566-0752e3c12dd7.png)
![transposed](https://cloud.githubusercontent.com/assets/7328215/3183184/40cef6d2-ec64-11e3-822a-d1ddfc6f0ed9.png)
as opposed to
This might not be the best way to fix this, but transposing bincounts before assigning the color values seems to work. So
Now correctly shows