Make spy() output nicer plots by default #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two primary differences compared to the previous implementation:
- the axes now are now compactly around the matrix, whereas previously there
was quite a lot of empty space, depending on the dimensions of the matrix
- zeroes now get drawn, but NaNs get filtered out
|
Looks great! I'll merge it in a day or two if no objections are raised. |
|
👍 |
darwindarak
added a commit
that referenced
this pull request
Dec 31, 2015
Make spy() output nicer plots by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small rewrite of the
spy()function to get better defaults. The differences compared to the current one arewas quite a lot of empty space, depending on the dimensions of the matrix
Everything can still be overridden by passing a custom
CoordorScale, so I do not think that this forces the user into anything, but these are better defaults if you just want to take a quick look at some arbitrary matrix.I.e. we go from this
to this
Plots produced by this simple script: https://gist.github.com/mortenpi/24730ed5f1b6de8976a4