Doc fixes and removal of ContinuousColorScale #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this file simply be removed?
For consistency with x_continuous, y_continuous. Note that ContinuousColorScale is still in Gadfly but no longer in the documentation. This introduces a new “colormap” keyword for color_continuous to replace ContinuousColorScale's “f” argument.
|
Wow, that's a lot of doc fixes. Thanks! |
timholy
added a commit
that referenced
this pull request
Jan 8, 2016
Doc fixes and removal of ContinuousColorScale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the changes around
ContinuousColorScaleandcolor_continuousdiscussed in #763. I took the opportunity to fix a bunch of typos and update a few things in the docs as well.I don't know how but the docs will need to be regenerated at some point. I suppose only @dcjones can do that.
I chose
colormapas the new keyword for the function that maps values in [0,1] to a color (my Matlab background is showing here, sorry). The name is of course open to discussion.