fixed show methods using Cairo for julia v0.5 #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try blocks behave differently in julia v0.5 compared to v0.4. The new behaviour caused the show methods requiring Cairo to be defined in local scope instead of global scope, which in turn prevented them from being used. See also: JuliaLang/julia#18767
1 similar comment
tlnagy
reviewed
Oct 4, 2016
| @@ -969,18 +969,16 @@ end | |||
|
|
|||
| try | |||
| getfield(Compose, :Cairo) # throws if Cairo isn't being used | |||
| @compat function show(io::IO, ::MIME"image/png", p::Plot) | |||
| @compat global show(io::IO, ::MIME"image/png", p::Plot) = | |||
There was a problem hiding this comment.
Shouldn't this be global function show?
There was a problem hiding this comment.
function can be omitted for online functions :-) I did remove function on purpose as in julia v0.4 the following code works:
try
global foo(x)=x+1
endwhile the following code raises an error:
try
global function foo(x)
x+1
end
endNevertheless, a different method for fixing this problem was suggested in JuliaLang/julia#18767 . So I'll give it a try. :-)
|
Thanks! I'm waiting for JuliaIO/FileIO.jl#85 to merge before I reboot the tests and make sure everything is okay. |
tlnagy
reviewed
Oct 5, 2016
| @compat function show(io::IO, ::MIME"application/postscript", p::Plot) | ||
| draw(PS(io, Compose.default_graphic_width, | ||
| Compose.default_graphic_height), p) | ||
| Compose.default_graphic_height), p); |
There was a problem hiding this comment.
Semi-colon is unnecessary, right?
|
So JuliaIO/FileIO.jl#85 is resolved and I rebooted the tests, if they are all green, I'll go ahead and merge this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try blocks behave differently in julia v0.5 compared to v0.4. The new
behaviour caused the show methods requiring Cairo to be defined in
local scope instead of global scope, which in turn prevented them from
being used. See also:
JuliaLang/julia#18767