Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i32 limits #18

Open
ekg opened this issue Mar 26, 2024 · 1 comment
Open

i32 limits #18

ekg opened this issue Mar 26, 2024 · 1 comment

Comments

@ekg
Copy link

ekg commented Mar 26, 2024

Great library! My only concern is that it seems to be hard coded to 32-bit signed integers for ranges and queries. There are a lot of genomes where there are chromosomes that exceed these limits. Either we special case these or relax and use 64 bits. How would you like a patch to enable 64 bit types?

@dcjones
Copy link
Owner

dcjones commented Mar 26, 2024

The SIMD versions have to be specialized on 32 bit integers, but the generic implementation could be pretty easily made generic on coordinate type. It would be just be a matter of adding another type parameter to the interval types, traits, and BasicCOITree type. This would be a worthwhile change, but my (maybe very human and mouse centric) impression was few work with chromosomes larger than 2gb so it hasn't been a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants