Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dcmqrscp: missing attributes in C-FIND responses #1123

Closed
gunterze opened this issue Feb 4, 2022 · 3 comments
Closed

dcmqrscp: missing attributes in C-FIND responses #1123

gunterze opened this issue Feb 4, 2022 · 3 comments
Assignees
Labels
Milestone

Comments

@gunterze
Copy link
Member

gunterze commented Feb 4, 2022

If there is no value available for a requested attribute, no attribute is included into the C-FIND response.
Instead an empty attribute shall be included into the C-FIND response.

@wigun
Copy link

wigun commented Feb 22, 2022

@gunterze Doesn't this violate the DICOM Conformance, since 'Type=1C attributes' like e.g. 'The Scheduled Protocol Code Sequence contains one or more Items.' (DICOM Standard, table K.6-1, PS 3.4) are added empty with this commit, if there is no respond for this?! I thought empty sequences like this have to be removed from the respond?!

@wigun
Copy link

wigun commented Feb 22, 2022

@gunterze And isn't it required that unsupported query/return keys should always be removed?

@gunterze
Copy link
Member Author

gunterze commented Feb 23, 2022

There are DICOM implementaions which claim on missing Type 2 attributes in C-FIND RSPs, if they were requested.
I am not aware of any DICOM implementation which claims against receive of empty Type 1C or Type 3 attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants