Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation Class UID and Implementation Version Name can be inconsistent #1238

Closed
janossch opened this issue Aug 15, 2022 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@janossch
Copy link

janossch commented Aug 15, 2022

Describe the bug
Since the solution of #1121 (commit: d60ddcf), there is no way to override implementation version name in an outbound association.

In my application I override the implementation UID with my own one, and it causes the situation that the UID and the name logically points to a different application.

So such situations may occur:

<6> 2022-08-15 11:15:32.169 +02:00 [INF] [org.dcm4che3.net.Association] - CALLING_AET->TEST_CALLED_AET(3) << A-ASSOCIATE-RQ
<7> 2022-08-15 11:15:32.169 +02:00 [DBG] [org.dcm4che3.net.Association] - A-ASSOCIATE-RQ[
calledAET: TEST_CALLED_AET
callingAET: CALLING_AET
applicationContext: 1.2.840.10008.3.1.1.1 - DICOM Application Context Name
implClassUID: 1.2.276.0.7230010.3.0.3.6.0
implVersionName: dcm4che-5.27.0
maxPDULength: 16384
maxOpsInvoked/maxOpsPerformed: 1/1
PresentationContext[id: 1
as: 1.2.840.10008.1.20.1 - Storage Commitment Push Model SOP Class
ts: 1.2.840.10008.1.2.1 - Explicit VR Little Endian
ts: 1.2.840.10008.1.2 - Implicit VR Little Endian
ts: 1.2.840.10008.1.2.2 - Explicit VR Big Endian (Retired)
]
RoleSelection[
sopClass: 1.2.840.10008.1.20.1 - Storage Commitment Push Model SOP Class
scu: false
scp: true
]
]

Is there any clean and suggested way to set our own ImplClassUID and ImplVersionName in an outbound association? I'm out of ideas, because:

  1. Implementation.getVersionName is a static method which returns a static field.
  2. AAssociateRQAC.setImplVersionName() is a final method so can not be overriden.

To Reproduce
Steps to reproduce the behavior:
2. create AAssociateRQ
3. use setImplClassUID() and setImplVersionName() methods on AAssociateRQ to override implementation UID and Version name with your own one to better recognize communication parties
4. use ApplicationEntity.connect() to establish remote association

Expected behavior
implClassUID and implVersionName (even if the second one is optional) can be overriden and stays consistent.

@gunterze gunterze self-assigned this Sep 7, 2022
@gunterze gunterze added the bug label Sep 7, 2022
@gunterze gunterze added this to the 5.28.0 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants