Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong VR for SourceApplicationEntityTitle in Attributes created by Association.createFileMetaInformation(..) #130

Closed
jib63 opened this issue Jul 4, 2017 · 3 comments
Assignees
Labels
Milestone

Comments

@jib63
Copy link

jib63 commented Jul 4, 2017

On the master ( and on the other branches ), on line 1228 of Association.java in createFileMetatInformation ( project dcm4che-net ) we can find :
fmi.setString(Tag.SourceApplicationEntityTitle, VR.SH, getRemoteAET());

The VR use shall be AE and not SH see the following link
https://www.dabsoft.ch/dicom/6/7/#(0002,0016)

This shall be changed to
fmi.setString(Tag.SourceApplicationEntityTitle, VR.AE, getRemoteAET());

@hczedik
Copy link
Member

hczedik commented Jul 4, 2017

@gunterze is this a typo or was it done on purpose?

@jib63
Copy link
Author

jib63 commented Jul 4, 2017

I told Gunter about this issue at last Connectathon in Venice. He agreed that it was a bad copy/pasting

@gunterze
Copy link
Member

gunterze commented Jul 5, 2017

Sorry, forgot to fix it. Thanks, for remembering.

@gunterze gunterze added the bug label Jul 5, 2017
@gunterze gunterze added this to the 3.3.9 milestone Jul 5, 2017
@gunterze gunterze changed the title Issue in Association.java method createFileMetaInformation ( on master ) Wrong VR for SourceApplicationEntityTitle in Attributes created by Association.createFileMetaInformation(..) Jul 5, 2017
gunterze added a commit that referenced this issue Jul 5, 2017
…ated by Association.createFileMetaInformation(..)
gunterze added a commit that referenced this issue Jul 5, 2017
…ated by Association.createFileMetaInformation(..)
hczedik pushed a commit that referenced this issue Jul 5, 2017
…ated by Association.createFileMetaInformation(..)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants