dcm4che/dcm4chee-arc-light#799 : dcm4che-tools-findscu: query params mentioned in dicom binary file or xml file is unused if specified after -m, -i or -r flags #118
Conversation
…mentioned in dicom binary file or xml file is unused if specified after -m, -i or -r flags
| if (optVals != null) | ||
| for (String key : optVals) { | ||
| File f = new File(key); | ||
| if (f.exists()) |
There was a problem hiding this comment.
Hi Vrinda,
this logic seems too complex. Why do you have to check if the argument is a file?
If option -r -m or -i is used, then the arguments following those options won't be a file, so e.g.:
findscu -i PatientName -i ModalitiesInStudy dicomfile.dcm
PatientName and ModalitiesInStudy are obviously not files, because they directly follow -i. On the other hand dicomfile.dcm is a file.
There was a problem hiding this comment.
Ah, I think I understand the problem now.
Maybe we should create these options with
.hasArg()
instead of
.hasArgs()
to avoid this ambigouity?
Just imagine the confusion should someone by conincidence have a file called e.g. "PatientName" in his working directory. Your current implementation is unpredictable.
There was a problem hiding this comment.
.hasArg() would avoid the ambiguity but break the current behavior to do not need to repeat -r -m or -i for specifying multiple arguments for the option. I would vote for keeping the current behavior, and investigate the effort to support the common CLI convention using -- to separate option arguments from program parameters
dcm4che/dcm4chee-arc-light#799