Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTful service: List Web Applications - Suppress Keycloak Client ID for local Web Services #2101

Closed
gunterze opened this issue Jul 25, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gunterze
Copy link
Member

gunterze commented Jul 25, 2019

Suppress Keycloak Client ID in returned list of Web Applications by GET /dcm4chee-arc/webapps for Web Applications secured by the same Keycloak realm as the UI of this Archive instance, where following System and KeycloakClient properties matches:

System property Keycloak Client property
System.getProperty("auth-server-url") keycloakServerURL
System.getProperty("realm-name", "dcm4che") keycloakRealm

Rationale:
Simplify for the UI to distinguish, if it has to fetch a new token by GET ​/token2​/{webAppName} or it can use the token it already has fetched from Keycloak.

Improves #1331
Requires dcm4che/dcm4che#509

@gunterze gunterze added the enhancement New feature or request label Jul 25, 2019
@gunterze gunterze added this to the 5.18.0 milestone Jul 25, 2019
gunterze added a commit that referenced this issue Jul 25, 2019
@gunterze gunterze changed the title RESTful service: List Web Applications - Provide all Keycloack Client attributes in returned list RESTful service: List Web Applications - Suppress Keycloak Client ID for local Web Services Jul 25, 2019
gunterze added a commit that referenced this issue Jul 25, 2019
vrindanayak added a commit to dcm4che/dcm4che that referenced this issue Jul 29, 2019
…ons - Suppress Keycloak Client ID for local Web Services
@vrindanayak vrindanayak reopened this Jul 30, 2019
vrindanayak added a commit to dcm4che/dcm4che that referenced this issue Jul 30, 2019
…pplications - Suppress Keycloak Client ID for local Web Services"

This reverts commit 834070f.
vrindanayak added a commit to dcm4che/dcm4che that referenced this issue Jul 30, 2019
…ons - Suppress Keycloak Client ID for local Web Services
vrindanayak added a commit that referenced this issue Jul 30, 2019
patrick-peer pushed a commit to patrick-peer/dcm4che that referenced this issue Oct 17, 2019
…ons - Suppress Keycloak Client ID for local Web Services
patrick-peer pushed a commit to patrick-peer/dcm4che that referenced this issue Oct 17, 2019
…pplications - Suppress Keycloak Client ID for local Web Services"

This reverts commit 834070f.
patrick-peer pushed a commit to patrick-peer/dcm4che that referenced this issue Oct 17, 2019
…ons - Suppress Keycloak Client ID for local Web Services
@petrkalina
Copy link
Collaborator

I believe it is relevant to check also if the keycloak client ID is dcm4chee-arc-ui - otherwise the client id is not returned for i.e.:

dn: dcmKeycloakClientID=arr-gatekeeper,dicomDeviceName=log,cn=Devices,cn=DICOM Configuration,dc=dcm4che,dc=org
objectClass: dcmKeycloakClient
dcmKeycloakClientID: arr-gatekeeper
dcmKeycloakRealm: dcm4che
dcmURI: https://auth:8843/auth
dcmKeycloakClientSecret: {secret}
dcmTLSAllowAnyHostname: TRUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants