Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform4: TAP Contents #31

Closed
kcoyle opened this issue May 27, 2021 · 6 comments
Closed

Transform4: TAP Contents #31

kcoyle opened this issue May 27, 2021 · 6 comments
Labels

Comments

@kcoyle
Copy link
Collaborator

kcoyle commented May 27, 2021

This should be just the minimum for this version. It could also be skipped if we run out of time, so ideally outputs should be completed before this is done.

  • valueNodeType = IRI, literal, or BNODE (case insensitive test)
  • unknown value for valueNodeType test
    • report as unknown value but output value
  • perhaps do not check Boolean values because we haven't yet provided a way to give alternates. Folks will know what values they used
  • shape is not referenced by a valueShape test
    • report as error but output
  • ??
@tombaker
Copy link
Collaborator

@kcoyle

valueNodeType as case insensitive
I have implemented this in 'dctap-python'.

valueNodeType unknown value
Will test whether the type is in the list and, if not, emit a warning. Are you saying that a bad value node type should be passed through to the output?

Boolean values
I have implemented these to accept "Y" and "N", but also some common variants one might expect, such as "y"/"n" and "True"/"False". These variants should be configurable by the user.

@kcoyle
Copy link
Collaborator Author

kcoyle commented Jun 10, 2021

Are you saying that a bad value node type should be passed through to the output?

I'm not saying that, I'm asking it as a question. I should have made that clear. These are all possible situations that one may encounter, so we should decide and document our decisions.

As for the Boolean, I agree that they should be configurable, but as we do not yet have a model for a configuration file we should discuss what values we want to accept as default.

I hope others will weigh in.

@tombaker
Copy link
Collaborator

tombaker commented Jun 10, 2021 via email

@kcoyle
Copy link
Collaborator Author

kcoyle commented Jun 11, 2021

My gut feeling is that warning but passing through is the way to go.

@tombaker
Copy link
Collaborator

tombaker commented Jun 11, 2021 via email

@kcoyle
Copy link
Collaborator Author

kcoyle commented Aug 11, 2021

See dctap-python documentation for resolution.

@kcoyle kcoyle closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants