Fix multiframe read/write #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use offset table for reading fragments if present, otherwise, loop until end of stream/sequence - Add option to not fragment encapsulated pixel data (use fragments equal to frame size) # Conflicts: # src/ValueRepresentation.js
|
🎉 This PR is included in version 0.16.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue I was seeing was with a multiframe US instance with no offset table (length == 0), and dcmjs would then assume there were no frames. This changes that behavior to go ahead and try to parse the pixel data sequence, which is what dicomParser does.
Discussion with others on the open source imaging zoom call seemed to suggest that pixel data fragmentation is partly an artifact of older machines that could not buffer entire large instances in memory. This adds an option not to fragment when writing encapsulated pixel data, which in my brief tests seems to be a lot faster for large cine instances.