fix: 🐛 relax condition in nearlyEquals check for detecting numbers near to zero

[Punzo]

Fix OHIF/Viewers#2869, see OHIF/Viewers#2869 (comment) for more info

[Punzo]

@pieper can you please review and merge, please?

[pieper]

@Punzo thanks for quick action on this 👍

Let's review it together on Thursday to make sure we fully understand what we want the behavior to be here. At the least we should update the comment since we are no longer following the logic of the source function from here: https://floating-point-gui.de/errors/comparison/. The current comment implies the code is still just a transliteration to javascript.

What I want to get a handle on is what a valid value of tolerance should be for data we reasonably expect to be displayed.

Since a common use case seems to be going to and from 32-bit float in a nifti1 header I'd like to take into account what rounding errors we are likely to see and set the tolerance to something that will be reasonable and robust.

[Punzo]

@Punzo thanks for quick action on this +1

Let's review it together on Thursday to make sure we fully understand what we want the behavior to be here. At the least we should update the comment since we are no longer following the logic of the source function from here: https://floating-point-gui.de/errors/comparison/. The current comment implies the code is still just a transliteration to javascript.

What I want to get a handle on is what a valid value of tolerance should be for data we reasonably expect to be displayed.

Since a common use case seems to be going to and from 32-bit float in a nifti1 header I'd like to take into account what rounding errors we are likely to see and set the tolerance to something that will be reasonable and robust.

Sure, let's discuss it next Thursday at the OHIF-IDC call.

[github-actions]

🎉 This PR is included in version 0.24.10 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀