Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README with better instructions for running tests. #1018

Merged
merged 1 commit into from Aug 7, 2017

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Jul 18, 2017

No description provided.

@klueska klueska requested a review from kensipe July 18, 2017 05:30
https://mesosphere.onelogin.com/notes/45791

For everyone else, you can still run the integration test suite against a non
EE cluster, but please be aware that some of the tests may fail.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem with this statement.. that non-ee cluster can be tested just be aware there may be failures...

  1. the tests stops immediate when it encounters an error.
  2. it will fail (not may fail) :)

@@ -137,6 +163,50 @@ Or, assuming you have tox installed (via :code:`sudo pip install tox`)::

tox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did all the things... and I get a failure on tests/integrations/test_config.py::test_dcos_url_env_var FAILED

>       assert stderr.startswith(
            b'URL [http://foobar/mesos/master/state.json] is unreachable')
E       assert False
E        +  where False = <built-in method startswith of bytes object at 0x7fe32b890800>(b'URL [http://foobar/mesos/master/state.json] is unreachable')
E        +    where <built-in method startswith of bytes object at 0x7fe32b890800> = b'Traceback (most recent call last):\n  File "/Users/kensipe/projects/dcos-cli/cli/.tox/py35-integration/lib/python3.5...("Expecting value", s, err.value) from None\njson.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)\n'.startswith

tests/integrations/test_config.py:200: AssertionError

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

output from stderr:

STDERR: Traceback (most recent call last):
  File "/Users/kensipe/projects/dcos-cli/cli/.tox/py35-integration/lib/python3.5/site-packages/dcoscli/subcommand.py", line 103, in run_and_capture
    exit_code = m.main([self._command] + self._args)
  File "/Users/kensipe/projects/dcos-cli/cli/.tox/py35-integration/lib/python3.5/site-packages/dcoscli/service/main.py", line 19, in main
    return _main(argv)
  File "/Users/kensipe/projects/dcos-cli/cli/.tox/py35-integration/lib/python3.5/site-packages/dcoscli/util.py", line 24, in wrapper
    result = func(*args, **kwargs)
  File "/Users/kensipe/projects/dcos-cli/cli/.tox/py35-integration/lib/python3.5/site-packages/dcoscli/service/main.py", line 32, in _main
    return cmds.execute(_cmds(), args)
  File "/Users/kensipe/projects/dcos-cli/dcos/cmds.py", line 43, in execute
    return function(*params)
  File "/Users/kensipe/projects/dcos-cli/cli/.tox/py35-integration/lib/python3.5/site-packages/dcoscli/service/main.py", line 89, in _service
    services = mesos.get_master().frameworks(
  File "/Users/kensipe/projects/dcos-cli/dcos/mesos.py", line 47, in get_master
    return Master(dcos_client.get_master_state())
  File "/Users/kensipe/projects/dcos-cli/dcos/mesos.py", line 118, in get_master_state
    return http.get(url, timeout=self._timeout).json()
  File "/Users/kensipe/projects/dcos-cli/cli/.tox/py35-integration/lib/python3.5/site-packages/requests/models.py", line 894, in json
    return complexjson.loads(self.text, **kwargs)
  File "/Users/kensipe/.pyenv/versions/3.5.3/lib/python3.5/json/__init__.py", line 319, in loads
    return _default_decoder.decode(s)
  File "/Users/kensipe/.pyenv/versions/3.5.3/lib/python3.5/json/decoder.py", line 339, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/Users/kensipe/.pyenv/versions/3.5.3/lib/python3.5/json/decoder.py", line 357, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there is a call to mesos for state... however the json decoder is failing instead of the expected unreachable url

@kensipe
Copy link
Contributor

kensipe commented Jul 18, 2017

@klueska I like the additions! however I'm still unable to run the tests successfully locally

@klueska klueska merged commit 86d8c7f into master Aug 7, 2017
@klueska klueska deleted the klueska/update-readme branch August 15, 2017 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants