Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored top level Jenkinsfile into smaller Jenkinsfiles. #1041

Merged
merged 1 commit into from Aug 23, 2017

Conversation

klueska
Copy link
Contributor

@klueska klueska commented Aug 18, 2017

There is now a subfolder called ci under which Jenkinsfiles for each of our various builds can be found ({linux, mac, windows}-binary and {linux, mac, windows}-integration-tests). Right now they are straight copies of the old Jenkinsfile, with the unnecessary stuff from building on other platforms / configurations stripped out. There is alot of cleanup / optimization that can happen from here. I just wanted to start with the smallest incremental change from the original as possible.

The build jobs these new Jenkinsfiles are linked to can be found here:
https://jenkins.mesosphere.com/service/jenkins/job/DCOS-CLI/job/mesosphere-dcos-cli/

@klueska klueska force-pushed the refactor-jenkins branch 28 times, most recently from 9e37d42 to 0f0f14c Compare August 22, 2017 07:22
@dcos dcos deleted a comment from mesosphere-ci Aug 22, 2017
@klueska klueska force-pushed the refactor-jenkins branch 17 times, most recently from c62e4e1 to 24953aa Compare August 22, 2017 09:54
@klueska klueska changed the title [WIP] Refactor CI into multiple builds. Refactored top level Jenkinsfile into smaller Jenkinsfiles. Aug 22, 2017
Copy link
Contributor

@bamarni bamarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM whenever Jenkins is happy, I'm in favor of iterating over this as a second step.

@klueska klueska force-pushed the refactor-jenkins branch 4 times, most recently from 144f9a4 to ba9a54c Compare August 22, 2017 22:15
There is now a subfolder called `ci` under which Jenkinsfiles for each
of our various builds can be found ({linux, mac, windows}-binary and
{linux, mac, windows}-integration-tests). Right now they are straight
copies of the old Jenkinsfile, with the unnecessary stuff from building
on other platforms / configurations stripped out. There is *alot* of
cleanup / optimization that can happen from here. I just wanted to start
with the smallest incremental change from the original as possible.
@klueska klueska merged commit 947ff35 into master Aug 23, 2017
@armandgrillet armandgrillet deleted the refactor-jenkins branch August 14, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants