Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mac-hh-yosemite Jenkins node for MacOS builds #1181

Merged
merged 1 commit into from Mar 23, 2018

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Mar 23, 2018

According to PyInstaller requirements :

PyInstaller builds apps that are compatible with the Mac OS X release in which you run it, and following releases.

Building from an old enough Mac makes sure we support all versions onwards. The latest Yosemite version was released 3 years ago, so it already brings a wide range of supported MacOS versions for the CLI.

The Jenkins node has Python 3.5.5 compiled with OpenSSL 1.0.2n.

https://jira.mesosphere.com/browse/DCOS_OSS-2290

According to PyInstaller requirements :

  PyInstaller builds apps that are compatible with the Mac OS X release
  in which you run it, and following releases.

Building from an old enough Mac makes sure we support all versions
onwards. The latest Yosemite version was released 3 years ago, so it
already brings a wide range of supported MacOS versions for the CLI.

The Jenkins node has Python 3.5.5 compiled with OpenSSL 1.0.2n.
@bamarni
Copy link
Contributor Author

bamarni commented Mar 23, 2018

run all integration tests

Copy link
Contributor

@armandgrillet armandgrillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an explanation regarding why does the integration tests pass on that node but not on our Jenkins nodes running on macOS Sierra?

@bamarni
Copy link
Contributor Author

bamarni commented Mar 23, 2018

Not yet, I will still try to run them on High Sierra with a binary built from Yosemite, as we didn't try this yet.

@bamarni bamarni merged commit 6cf8ca4 into dcos:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants