0.6.1 release #1201
Closed
0.6.1 release #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is called when reading a password or service account key file. It is common to have a trailing newline in files. In the case of a private key it doesn't harm but for passwords these trailing whitespace(s) shouldn't be considered as part of the credentials. Fixes dcos#1167
According to PyInstaller requirements : PyInstaller builds apps that are compatible with the Mac OS X release in which you run it, and following releases. Building from an old enough Mac makes sure we support all versions onwards. The latest Yosemite version was released 3 years ago, so it already brings a wide range of supported MacOS versions for the CLI. The Jenkins node has Python 3.5.5 compiled with OpenSSL 1.0.2n.
Previously, there were problems with the way patterns were matched for the task ID when calling `task exec`. Specifically, it didn't follow the semantics indicated in the help string for (1) matching regular expressions and (2) matching any substring within the ID, not just the prefix of the ID. The reason we did not adhere to these semantics is because we were trying to match the exact semantics of `docker exec`, which only allows prefix matching, not arbitrary regex or 'contains()' like semantics for pattern matching the ID. With this change, we have decided to break from the docker semantics and use the default pattern matching semantics provided by the dcos-cli library command for pattern matching task ids. Unfortunately, there is a bug in this library, and regular expressions are not supported! However, arbitrary substring pattern mathing is. This commit, therefore, updates the semantics of `task exec` to adhere to 'contains()' like smeantics within the task ID for the 'task_id' parameter passed to it, but does not yet support proper regular expression pattern matching. A subsequent commit will be added to fix regex matching in library call implementing task ID pattern matching.
Don't run `pip install --upgrade pip` on Windows, it started to fail in our Jenkins node and this is not the right command. https://jira.mesosphere.com/browse/DCOS_OSS-2332 https://pip.pypa.io/en/stable/installing/#upgrading-pip pypa/pip#1299
This makes it more precise as it accepts Unix file pattern wildcards instead of regexes.
|
run all integration tests |
armandgrillet
previously approved these changes
Apr 5, 2018
|
I will include #1202 before merging. |
This re-arranges our Jenkinsfiles now that we have the Go project. The relevant status checks have been added to Jenkins : - all-go-binaries - linux-go-tests - linux-integration-tests - linux-python-binary - mac-integration-tests - mac-python-binary - windows-integration-tests - windows-python-binary
Depending on the user setup, they might contain an incorrect scheme. This is because Cosmos relies in the scheme used to query admin router. If a CLI is configured to use HTTPS but a load balancer sits in front of admin router and does TLS termination, these URLs will use the HTTP scheme. Not only that it is a security concern, it would simply fail on setups which don't support HTTPS. This is hopefully a temporary fix until we come-up with a long-term fix in DC/OS. Fixes dcos#1190 https://jira.mesosphere.com/browse/COPS-3052 https://jira.mesosphere.com/browse/DCOS_OSS-2325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.