Encapsulate build logic with bash and a Makefile. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| fi | ||
|
|
||
| cd $BASEDIR | ||
| export PYTHONPATH=. |
There was a problem hiding this comment.
Didn't we have to remove this to make it work?
There was a problem hiding this comment.
It was the PYTHONPATH in the test driver script that caused issues, but I'll get rid of this as well.
|
Addressed comments. |
|
Looks good! Thanks for doing this! |
jsancio
added a commit
that referenced
this pull request
Jan 28, 2015
Encapsulate build logic with bash and a Makefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ssk2 @jsancio
Now you can just check out the project and type
make!