Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard the local login server on non-desktop environment #1502

Merged
merged 1 commit into from
Oct 15, 2019

Commits on Oct 14, 2019

  1. Discard the local login server on non-desktop environment

    For the `dcos-oidc-auth0` login provider, when the user operates the CLI
    from a container or a remote machine, the local webserver will not run
    on the same machine as the browser. Later on the browser will try to
    send the token to eg. `localhost:43383`, which won't be reachable.
    
    When this situation arises, we had designed the UI to fallback to
    printing the login token for copy-pasting, but once the CLI has
    successfully initiated the local web server, it doesn't accept input
    from STDIN at all, so the user has no chance to copy-paste the token.
    
    This commit updates the CLI to fallback to reading from STDIN when the
    browser can't be opened.
    
    Note: as an alternative, it would have been possible to concurrently
    wait for data on both the local web server and STDIN, but the current
    fix is simpler and covers the container / remote use-cases as expected.
    
    https://jira.mesosphere.com/browse/DCOS_OSS-5591
    bamarni committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    fe9242e View commit details
    Browse the repository at this point in the history