Accept ACS token passed in env to auth login #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janisz
force-pushed
the
accept_acs_token_passed_with_env
branch
from
110b848
to
d49312e
Compare
pierrebeitz
previously approved these changes
Aug 14, 2020
janisz
force-pushed
the
accept_acs_token_passed_with_env
branch
from
c3bffb8
to
d49312e
Compare
dcos cluster setup accepts ACS Toekn set in DCOS_CLUSTER_SETUP_ACS_TOKEN environment variable. This PR will add the same behaviour to auth login. Fixes: https://jira.d2iq.com/browse/COPS-6421
janisz
force-pushed
the
accept_acs_token_passed_with_env
branch
from
d49312e
to
76fdc5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcos cluster setupaccepts ACS token set inDCOS_CLUSTER_SETUP_ACS_TOKENenvironment variable. This PR will add the same behavior to
dcos auth login.Fixes: https://jira.d2iq.com/browse/COPS-6421