DCOS-514: use readable tables in the output of many commands #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ("NAME", lambda t: t["name"]), | ||
| ("USER", lambda t: t.user()), | ||
| ("STATE", lambda t: t["state"].split("_")[-1][0]), | ||
| ("ID", lambda t: t["id"]), |
There was a problem hiding this comment.
Should we bump ID up to the first column?
There was a problem hiding this comment.
I don't think so. NAME is the human readable version, which is what we want most prominent to users. ID is a base 16 clusterfuck that should only be consumed by computers.
mgummelt
force-pushed
the
dcos-514-deployment-list
branch
from
0cdba9f
to
180a383
Compare
|
|
||
| def _task(fltr, completed, is_json): | ||
| """ List DCOS tasks | ||
| def _task(fltr, completed, json_): |
There was a problem hiding this comment.
Why can't we use the word filter here?
mgummelt
force-pushed
the
dcos-514-deployment-list
branch
from
180a383
to
66555f5
Compare
|
Alright, aside from the "Null" for container type, I'm happy with this. |
mgummelt
force-pushed
the
dcos-514-deployment-list
branch
4 times, most recently
from
9a8fd0e
to
cd00751
Compare
mgummelt
force-pushed
the
dcos-514-deployment-list
branch
from
cd00751
to
5025920
Compare
mgummelt
added a commit
that referenced
this pull request
Jun 4, 2015
DCOS-514: use readable tables in the output of many commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocked on #189