dcos-4134 integrate with acs AuthN flow #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # using private method here, so we don't retry on this request | ||
| # error here will be bubbled up to _request_with_auth | ||
| response = _request('post', url, json=creds) | ||
| if response.status_code == 200: |
There was a problem hiding this comment.
What happens if the status_code is not 200?
There was a problem hiding this comment.
I think I get it. If the header is not set then the following call will get fail with a 400.
tamarrow-zz
force-pushed
the
dcos-4134
branch
from
dfd6b20
to
7539e6d
Compare
|
@jsancio updated with changes we talked about today |
tamarrow-zz
force-pushed
the
dcos-4134
branch
from
7539e6d
to
36071ff
Compare
|
|
||
| token = None | ||
| if response.status_code == 200: | ||
| token = response.json()['token'] |
There was a problem hiding this comment.
Okay. Or token = response.json().get('token') if response.status_code == 200 else None if we want functional code.
|
Looks great! |
tamarrow-zz
pushed a commit
that referenced
this pull request
Jan 27, 2016
dcos-4134 integrate with acs AuthN flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.