default requests to cosmos to version 2, with a version 1 fallback #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :returns: header information | ||
| :rtype: str | ||
| """ | ||
|
|
||
| return ("application/vnd.dcos.package.{}+json;" | ||
| "charset=utf-8;version=v1").format(request_type) | ||
| "charset=utf-8;version={}").format(request_type, version) |
There was a problem hiding this comment.
I think we should instead construct all of the possible content type ahead of time. For example most RPCs in Cosmos are going to stay as v1. The type of this my could be: Map[String, List[String], the key is the request_type and the value is a list of supported content-type in preference order. What do you think?
tamarrow-zz
force-pushed
the
cosmos-v2
branch
2 times, most recently
from
216f3fb
to
d63b114
Compare
|
@jsancio can you review please? I removed your commit so that tests will pass (once testing/master is updated to 1.8 we can merge your pr) |
tamarrow-zz
force-pushed
the
cosmos-v2
branch
4 times, most recently
from
453a6ac
to
efdf6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#655