Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging tests to work with the latest version of DC/OS #998

Merged
merged 2 commits into from
May 22, 2017
Merged

Fix packaging tests to work with the latest version of DC/OS #998

merged 2 commits into from
May 22, 2017

Conversation

larioj
Copy link
Contributor

@larioj larioj commented May 19, 2017

This fixes tests that check labels that no longer exists. It also changes the universe servers used by the tests since the old version cannot handle the new requests.

Copy link
Contributor

@jsancio jsancio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank @larioj

@karlkfi
Copy link
Contributor

karlkfi commented May 19, 2017

Ignore the test-install-script-multijob test. It was added for another PR that isn't merged yet.

Copy link
Contributor

@cruhland cruhland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tamarrow-zz
Copy link
Contributor

@larioj your experimental tests failed: https://teamcity.mesosphere.io/viewLog.html?buildId=655874&buildTypeId=DcosIo_DcosCli_OsX_MacBinary&guest=1

@karlkfi please do not add your job to github reporting yet. Also if would be better to add it to the existing CIs so we don't have more CIs to manage.

@larioj
Copy link
Contributor Author

larioj commented May 19, 2017

@tamarrow Yeah, I saw that. The latest changes should fix that.

@karlkfi
Copy link
Contributor

karlkfi commented May 20, 2017

@tamar: I'll disable the MultiJob build trigger.

I added it to Jenkins because the non-windows tests for the cli still haven't been migrated from TeamCity yet.

My new MultiJob build can easily have new tests added to it as separate parallel or serial jobs if you want to test on the same cluster. It should make migrating to Jenkins trivial.

If you know how to execute win-bash in Jenkins I can add the Windows test.

@tamarrow-zz
Copy link
Contributor

tamarrow-zz commented May 21, 2017

@mesosphere-ci retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants