fix l4lb delete lvs services unexpectedly #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l4lb manager has a mistake when caculating services to deleted and
and to added.
for example, we have 1,2,4,5 vips originally, and new vip 3 is added,
so we have the following execution according to function generate_diff
oldvips newvips toAdd toDelete Mutation
1. [1,2,4,5] [1,2,3,4,5]
2. [2,4,5] [2,3,4,5] [] [] []
3. [4,5] [3,4,5] [] [] []
4. [5] [3,4,5] [] [4] []
5. [] [3,4,5] [] [4,5] []
return [3,4,5] [4,5] []
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 67.96% 68.03% +0.06%
==========================================
Files 48 48
Lines 2897 2900 +3
==========================================
+ Hits 1969 1973 +4
+ Misses 928 927 -1
Continue to review full report at Codecov.
|
This was referenced Jul 13, 2018
[1.11] fix l4lb delete lvs services unexpectedly
|
@mainred thank you very much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.mesosphere.com/browse/DCOS_OSS-3602
l4lb manager has a mistake when caculating services to deleted and
and to added.
for example, we have 1,2,4,5 vips originally, and new vip 3 is added,
so we have the following execution according to function generate_diff