ssh client copy_file bidirectional instead of always assuming local to remote copy #42
Conversation
margaret
force-pushed
the
bidirectional_copy
branch
from
ebcad1d
to
1412ccf
Compare
dcos_test_utils/ssh_client.py
Outdated
| cmd = ['scp'] + self.opt_list + ['-P', str(self.port)] + copy_command | ||
| log.debug('Copying {} to {}'.format(src, remote_full_path)) | ||
| log.debug('Copying {} to {}'.format(*copy_command)) |
There was a problem hiding this comment.
Does this log statement work if copy_command includes the -r? That would be more than 2 arguments?
There was a problem hiding this comment.
Ahh good catch, that wouldn't work. It doesn't throw an exception but it would log -r to src
There was a problem hiding this comment.
Just needs a fix for the log statement that @colin-msphere pointed out and then we should be able to merge this
|
Not sure why the tests aren't reporting. I triggered them manually. ✅ Tox https://teamcity.mesosphere.io/viewLog.html?buildId=1021388&tab=buildResultsDiv&buildTypeId=DcosIo_DcosTestUtils_ToxIntegrationTestEnterprise |
|
Oooo that's what the 'update branch' button does. Updates with master. |
It still defaults to assuming local->remote, so previous uses of it shouldn't be affected