Skip to content

Commit

Permalink
fix: increase retries and timeout
Browse files Browse the repository at this point in the history 
We have flaky CI for master. Many test fails due to
> Timed out retrying: Expected to find element
This change should fix it for now until we debug real cause.
  • Loading branch information
@janisz
janisz committed Sep 17, 2020
1 parent 56b4c75 commit 108e3e2
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cypress.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"chromeWebSecurity": false,
"defaultCommandTimeout": 60000,
"defaultCommandTimeout": 120000,

This comment has been minimized.

Sign in to view

Copy link
@pierrebeitz

pierrebeitz Sep 21, 2020 •
edited
Loading

Contributor

@janisz did that help anything? it would be awesome if we could have the build green this easily. :)

usually our flakes should have nothing to do with that timeout and it will only increase the time our tests run as cypress is waiting longer for things that don't ever happen.
i think the real problem is dcos-ui itself having tons of race conditions due to it's architecture.

This comment has been minimized.

Sign in to view

Copy link
@janisz

janisz Sep 21, 2020

Author Contributor

No, test passed but then failed again :(

This comment has been minimized.

Sign in to view

Copy link
@pierrebeitz

pierrebeitz Sep 21, 2020

Contributor

i'd vote to decrease the timeout again. i'd even vote to decrease it even further as the default is 4000 and if i remember correctly this was increased in a hurry.
"env": {
"CLUSTER_URL": "http://localhost:4200"
},
Expand All @@ -9,6 +9,7 @@
"pageLoadTimeout": 600000,
"projectId": "a209b1cd-e44f-47a4-b22c-d8f26649f43f",
"reporter": "junit",
"retries": 3,

This comment has been minimized.

Sign in to view

Copy link
@pierrebeitz

pierrebeitz Sep 21, 2020

Contributor

@janisz i think this is only doing something in cypress >=5, which we don't use yet, right?

This comment has been minimized.

Sign in to view

Copy link
@janisz

janisz Sep 21, 2020

Author Contributor

Oh, can we update?

This comment has been minimized.

Sign in to view

Copy link
@pierrebeitz

pierrebeitz Sep 21, 2020

Contributor

it would be awesome if someone could figure out how feasible updating is: #4836

updating from 3 to 4 was a PITA. this time it looks like they've introduced some mechanisms to automatically compile test-files via babel/typescript, which does not seem to work with our configs. might be tough to resolve. but maybe we can just turn that off?
"screenshotsFolder": "cypress/screenshots",
"supportFile": "tests/_support",
"trashAssetsBeforeRuns": false,
Expand Down

0 comments on commit 108e3e2

Please sign in to comment.